Make saved searches with names work in saved_search/saved_search.py

Shakeel Mohamed · Shakeel Mohamed · commit e6fa1920c022 · 2015-07-15T16:53:45.000-07:00
Also added some tests, and fixed a readme typo.
diff --git a/examples/saved_search/README.md b/examples/saved_search/README.md
@@ -8,7 +8,7 @@ saved search actions.
 `list` and `delete` requires the `--name` argument to either list the contents 
 of a specific saved search or delete a specific saved search.
 
-`create` requires the `--name` argument, as well as a littany of other arguments 
+`create` requires the `--name` argument, as well as a list of any other arguments 
 to establish a saved search. The help output is seen below.
 
 Of special note is the events that can perform actions (`--actions` and 
diff --git a/examples/saved_search/saved_search.py b/examples/saved_search/saved_search.py
@@ -174,15 +174,15 @@ def main(argv):
             if key == "operation":
                 operation = opts.kwargs[key]
             else:
-                kwargs[key] = urllib.quote(opts.kwargs[key])
+                kwargs[key] = opts.kwargs[key]
 
     # no operation? if name present, default to list, otherwise list-all
     if not operation:
         if kwargs.has_key('name'):
             operation = 'list'
         else:
             operation = 'list-all'
-
+    
     # pre-sanitize
     if (operation != "list" and operation != "create" 
                             and operation != "delete"
diff --git a/tests/test_examples.py b/tests/test_examples.py
@@ -195,7 +195,19 @@ def test_saved_searches(self):
         self.check_commands(
             "saved_searches.py --help",
             "saved_searches.py")
-        
+    
+    def test_saved_search(self):
+        temp_name = testlib.tmpname()
+        self.check_commands(
+            "saved_search/saved_search.py",
+            ["saved_search/saved_search.py", "--help"],
+            ["saved_search/saved_search.py", "list-all"],
+            ["saved_search/saved_search.py", "--operation", "create", "--name", temp_name, "--search", "search * | head 5"],
+            ["saved_search/saved_search.py", "list", "--name", temp_name],
+            ["saved_search/saved_search.py", "list", "--operation", "delete", "--name", temp_name],
+            ["saved_search/saved_search.py", "list", "--name",  "Top five sourcetypes"]
+        )
+
     def test_search(self):
         self.check_commands(
             "search.py --help",
