Replace tarfile.add() named arguments with positional arguments.

Shakeel Mohamed · Shakeel Mohamed · commit 94541129ec5b · 2015-07-16T16:07:34.000-07:00
This change was made to maintain compatibility with Python 2.6 and Python 2.7, and follows the suggested fix in the docs: https://docs.python.org/2/library/tarfile.html#tarfile.TarFile.add In Python 2.6, the `exclude` named argument was added. In Python 2.7, the `filter` named argument was added, and `exclude` was deprecated.
diff --git a/setup.py b/setup.py
@@ -168,7 +168,6 @@ def run(self):
         sdk_dir = os.path.abspath('.')
 
         def exclude(path):
-            # TODO: DVPL-5866 - Replace with filter function because exclude is deprecated
             basename = os.path.basename(path)
             for pattern in ['.DS_Store', '.idea', '*.log', '*.py[co]']:
                 if fnmatch(basename, pattern):
@@ -189,7 +188,8 @@ def exclude(path):
 
         with closing(tarfile.open(tarball, 'w')) as spl:
             for source, target in manifest:
-                spl.add(source, arcname=target, exclude=exclude)
+                # Args here are: name, arcname, recursive, and [exclude|filter]
+                spl.add(source, target, True, exclude)
 
         return
 
