Fix test_touch Job test by checking update time instead of TTL

Shakeel Mohamed · Shakeel Mohamed · commit 5d788b09e2cd · 2015-08-04T16:34:41.000-07:00
Needed to expose the updated field to make this possible.
diff --git a/splunklib/client.py b/splunklib/client.py
@@ -256,7 +256,8 @@ def _parse_atom_entry(entry):
         'links': links,
         'access': metadata.access,
         'fields': metadata.fields,
-        'content': content
+        'content': content,
+        'updated': entry.get("updated")
     })
 
 
diff --git a/tests/test_job.py b/tests/test_job.py
@@ -341,21 +341,19 @@ def test_setttl(self):
         self.assertGreater(ttl, old_ttl)
 
     def test_touch(self):
-        # This cannot be tested very fast. touch will reset the ttl to the
-        # original value for the job, so first we have to wait just long enough
-        # for the ttl to tick down. Its granularity is 1s, so we'll wait a
-        # couple of seconds before we start.
         while not self.job.is_done():
             pass
         sleep(2)
         self.job.refresh()
-        old_ttl = int(self.job['ttl'])
+        old_updated = self.job.state.updated
         self.job.touch()
+        sleep(2)
         self.job.refresh()
-        new_ttl = int(self.job['ttl'])
-        if new_ttl == old_ttl:
-            self.fail("Didn't wait long enough for TTL to change and make touch meaningful.")
-        self.assertGreater(int(self.job['ttl']), old_ttl)
+        new_updated = self.job.state.updated
+
+        # Touch will increase the updated time
+        self.assertLess(old_updated, new_updated)
+
 
     def test_search_invalid_query_as_json(self):
         args = {
