-
Notifications
You must be signed in to change notification settings - Fork 97
Closed
Labels
BugError, flaw or fault to produce incorrect or unexpected resultsError, flaw or fault to produce incorrect or unexpected resultsRelease_2.x.yOnly for the major release 2Only for the major release 2Release_3.x.yOnly for the major release 3Only for the major release 3
Description
Situation
If you pass negative numbers into semver.VersionInfo
it doesn't raise any errors:
>>> import semver
>>> semver.VersionInfo(-2)
VersionInfo(major=-2, minor=0, patch=0, prerelease=None, build=None)
Tested with latest 2.11.0
Proposal
I guess, this shouldn't happen. We should raise a ValueError exception.
Would integrate that into a 2.12.0 release and into the upcoming 3.0.0-alpha0.
@tlaferriere Thomas, can you conform? Do you agree?
Metadata
Metadata
Assignees
Labels
BugError, flaw or fault to produce incorrect or unexpected resultsError, flaw or fault to produce incorrect or unexpected resultsRelease_2.x.yOnly for the major release 2Only for the major release 2Release_3.x.yOnly for the major release 3Only for the major release 3