-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
enhancementA new feature idea that would improve the packageA new feature idea that would improve the packageshortlist
Description
Summary
python-docx
raises:
docx.opc.exceptions.PackageNotFoundError: Package not found at '/a/b/c.docx'
on Document("/a/b/c.docx")
when the file or path provided does not resolve to a ZIP archive. For diagnostic purposes it would be better to distinguish a No such file or directory
condition from a file exists but is not a ZIP archive (and so not a DOCX file)
condition.
Proposed
- Add a separate
os.file.isfile()
test on a provided file-path before attempting to open it withzipfile
. Give this a focused message likeFileNotFoundError: No such file or directory: '/a/b/c.docx'
so the problem is unambiguous. - Change the
PackageNotFoundError
text to more specifically indicate the file is not a zip archive.
Metadata
Metadata
Assignees
Labels
enhancementA new feature idea that would improve the packageA new feature idea that would improve the packageshortlist