@haplo is there anything i could help you with, working on this?

I put it on pause waiting for the new ruff command that will do formatting and linting, so feel free to work on this.

Change is straightforward, just update run_ruff_format to include an extra run_ruff that calls ruff format after the imports have been sorted:

python-lsp-ruff/pylsp_ruff/plugin.py

Lines 416 to 434 in be27747

    
           def run_ruff_format( 
        
               settings: PluginSettings, 
        
               document_path: str, 
        
               document_source: str, 
        
           ) -> str: 
        
               fixable_codes = ["I"] 
        
               if settings.format: 
        
                   fixable_codes.extend(settings.format) 
        
               extra_arguments = [ 
        
                   f"--fixable={','.join(fixable_codes)}", 
        
               ] 
        
               result = run_ruff( 
        
                   settings=settings, 
        
                   document_path=document_path, 
        
                   document_source=document_source, 
        
                   fix=True, 
        
                   extra_arguments=extra_arguments, 
        
               ) 
        
               return result

Do add/update tests and documentation too.

@jhossbach I think as part of this work we should update the ruff dependency on python-lsp-ruff to the first ruff version with format support (0.1.2).

You can tag me in the pull request, would be happy to give it a try and review.

	def run_ruff_format(
	settings: PluginSettings,
	document_path: str,
	document_source: str,
	) -> str:
	fixable_codes = ["I"]
	if settings.format:
	fixable_codes.extend(settings.format)
	extra_arguments = [
	f"--fixable={','.join(fixable_codes)}",
	]
	result = run_ruff(
	settings=settings,
	document_path=document_path,
	document_source=document_source,
	fix=True,
	extra_arguments=extra_arguments,
	)
	return result

Support ruff format #53

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Support `ruff format` #53