Skip to content

Update notes api for ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

massimiliano96
Copy link
Contributor

Changes

Add ListMixin to ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the API for discussion note managers by replacing explicit mixin inheritance with a more concise CRUDMixin approach for both issue and merge request discussion notes.

  • Consolidates multiple explicit mixins (GetMixin, CreateMixin, UpdateMixin, DeleteMixin) into a single CRUDMixin for cleaner inheritance
  • Updates both ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager classes

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (be25c16) to head (15ff9d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3233   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          98       98           
  Lines        6058     6058           
=======================================
  Hits         5896     5896           
  Misses        162      162           
Flag Coverage Δ
api_func_v4 83.69% <100.00%> (-0.05%) ⬇️
cli_func_v4 84.69% <100.00%> (ø)
unit 90.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/v4/objects/notes.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnVillalovos
Copy link
Member

@massimiliano96 This looks good to me. Only suggestion is that in one of the commit messages add a Closes: #3180

So that when it gets merged the issue will get closed.

Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @massimiliano96

@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) July 18, 2025 16:15
@JohnVillalovos JohnVillalovos merged commit f908f0e into python-gitlab:main Jul 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants