chore(test): prevent 'job_with_artifact' fixture running forever

JohnVillalovos · JohnVillalovos · commit 19573b41c329 · 2025-01-22T07:55:48.000-08:00
Previously the 'job_with_artifact' fixture could run forever. Now give
it up to 60 seconds to complete before failing.
diff --git a/tests/functional/cli/test_cli_artifacts.py b/tests/functional/cli/test_cli_artifacts.py
@@ -24,12 +24,24 @@
 
 @pytest.fixture(scope="module")
 def job_with_artifacts(gitlab_runner, project):
+    start_time = time.time()
+
     project.files.create(data)
 
     jobs = None
     while not jobs:
         time.sleep(0.5)
         jobs = project.jobs.list(scope="success")
+        if time.time() - start_time > 60:
+            print("ERROR: job never succeeded")
+            for job in project.jobs.list():
+                job = project.jobs.get(job.id)
+                job.pprint()
+                if job.status == "failed":
+                    print()
+                    print("job log/trace:", job.trace())
+                print()
+            assert None, "Fixture 'job_with_artifact' failed"
 
     return project.jobs.get(jobs[0].id)
 
