Skip to content

gh-136438: Make sure test_remote_pdb pass with all optimization levels #136788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2025
Merged

gh-136438: Make sure test_remote_pdb pass with all optimization levels #136788

merged 3 commits into from
Jul 20, 2025
+33 −20

Conversation

olp-cs
Copy link
Contributor

@olp-cs olp-cs commented Jul 19, 2025 •
edited
Loading

Related to #136438

  • New test cases for the scenario when no help is available.
  • Skip test cases not relevant for the current optimization level.

Details

Help is not available for the optimization level -OO.

please do not run Python with -OO if you need command help

(pdb.py, lines 2439-2440)

Testing

With -OO

./python -OO -m test test_remote_pdb -v

test_handling_help_when_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_available) ... skipped 'Help not available for -OO'
test_handling_help_when_not_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_not_available) ... ok

Without -OO

./python -m test test_remote_pdb -v

test_handling_help_when_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_available)
Test handling help requests when help is available. ... ok
test_handling_help_when_not_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_not_available)
Test handling help requests when help is not available. ... skipped 'Needs -OO'

At EuroPython Sprints with @encukou

@olp-cs olp-cs requested a review from gaogaotiantian as a code owner July 19, 2025 10:44
@python-cla-bot
Copy link

python-cla-bot bot commented Jul 19, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jul 19, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jul 19, 2025
Open
8 tasks
encukou
encukou approved these changes Jul 19, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's merge this :)

Please don't update the branch; GitHub has a prominent button fo that but all it does here is restart the test run.

ZeroIntensity
ZeroIntensity approved these changes Jul 19, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensity
Copy link
Member

Oh, oops, you beat me to it.

@encukou encukou merged commit 588d9fb into python:main Jul 20, 2025
46 checks passed
@encukou encukou added the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
@miss-islington-app
Copy link

Thanks @olp-cs for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @olp-cs and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 588d9fb84ae014502811ec8580411ea0df7200fe 3.14

@encukou
Copy link
Member

encukou commented Jul 20, 2025

Thank you, @olp-cs?
Would you be interested in backporting this into the 3.14 branch?

@olp-cs
Copy link
Contributor Author

olp-cs commented Jul 20, 2025 •
edited
Loading

@encukou Thank you, I'll look into this!

Update: backport to 3.14 #136855

olp-cs added a commit to olp-cs/cpython that referenced this pull request Jul 20, 2025
@olp-cs
pythongh-136438: Make sure test_remote_pdb pass with all optimizati…
8d07aa9 
…on levels (pythonGH-136788)

(cherry picked from commit 588d9fb)
@olp-cs olp-cs mentioned this pull request Jul 20, 2025
Merged
@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2025

GH-136855 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
encukou pushed a commit that referenced this pull request Jul 20, 2025
@olp-cs
[3.14] gh-136438: Make sure test_remote_pdb pass with all optimizat…
0e90926 
…ion levels (GH-136788) (GH-136855)

(cherry picked from commit 588d9fb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner

Assignees

@encukou encukou

Labels
skip news sprint tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olp-cs @ZeroIntensity @encukou @AA-Turner @StanFromIreland