Skip to content

gh-136764: improve comment in enum.verify.__call__ #136774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

gh-136764: improve comment in enum.verify.__call__ #136774

merged 1 commit into from
Jul 19, 2025
+1 −1

Conversation

damngamerz
Copy link
Contributor

@damngamerz damngamerz commented Jul 19, 2025 •
edited
Loading

@damngamerz damngamerz requested a review from ethanfurman as a code owner July 19, 2025 08:54
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jul 19, 2025
Closed
@bedevere-app

This comment was marked as duplicate.

Sign in to view
auvipy
auvipy approved these changes Jul 19, 2025
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds better

@ethanfurman ethanfurman merged commit 6a1c93a into python:main Jul 19, 2025
48 checks passed
@ethanfurman ethanfurman added 3.13 bugs and security fixes 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 19, 2025
@miss-islington-app
Copy link

Thanks @damngamerz for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @damngamerz for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
@damngamerz @miss-islington
pythongh-136764: improve comment in enum.verify.__call__ (pythonGH-13…
4368cfb 
…6774)

(cherry picked from commit 6a1c93a)

Co-authored-by: Saurav Singh <sauravsinghshakya@yahoo.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
@damngamerz @miss-islington
pythongh-136764: improve comment in enum.verify.__call__ (pythonGH-13…
0cafae7 
…6774)

(cherry picked from commit 6a1c93a)

Co-authored-by: Saurav Singh <sauravsinghshakya@yahoo.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2025

GH-136841 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2025

GH-136842 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2025
ethanfurman pushed a commit that referenced this pull request Jul 19, 2025
@miss-islington @damngamerz
[3.14] gh-136764: improve comment in enum.verify.__call__ (GH-136774) (…
197f3ec 
…GH-136841)

gh-136764: improve comment in enum.verify.__call__ (GH-136774)
(cherry picked from commit 6a1c93a)

Co-authored-by: Saurav Singh <sauravsinghshakya@yahoo.com>
ethanfurman pushed a commit that referenced this pull request Jul 19, 2025
@miss-islington @damngamerz
[3.13] gh-136764: improve comment in enum.verify.__call__ (GH-136774) (…
f7be0ee 
…GH-136842)

gh-136764: improve comment in enum.verify.__call__ (GH-136774)
(cherry picked from commit 6a1c93a)

Co-authored-by: Saurav Singh <sauravsinghshakya@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes skip news sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damngamerz @auvipy @ethanfurman @encukou @AA-Turner