Skip to content

gh-127146: Emscripten: Make os.umask() actually work #136706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

gh-127146: Emscripten: Make os.umask() actually work #136706

merged 1 commit into from
Jul 16, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jul 16, 2025 •
edited by freakboy3742
Loading

At least when run in Node.

Fixes #135783.

umask still has a lot of issues, but will require upstream fixes in Emscripten.

@bedevere-app bedevere-app bot mentioned this pull request Jul 16, 2025
Closed
@freakboy3742
Copy link
Contributor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 6b4911a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136706%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

freakboy3742
freakboy3742 approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 12e52ca into python:main Jul 16, 2025
52 of 53 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2025
@hoodmane @miss-islington
pythongh-127146: Emscripten: Make os.umask() actually work (pythonGH-…
fc2c113 
…136706)

Provide a stub implementation of umask that is enough to get some tests passing.
More work is needed upstream in Emscripten to make all umask tests to pass.
(cherry picked from commit 12e52ca)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 16, 2025

GH-136711 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 16, 2025
freakboy3742 pushed a commit that referenced this pull request Jul 16, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Emscripten: Make os.umask() actually work (GH-136706)…
4eee754 
… (#136711)

Provide a stub implementation of umask that is enough to get some tests passing.
More work is needed upstream in Emscripten to make all umask tests to pass.
(cherry picked from commit 12e52ca)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
OS-emscripten skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

umasked os.makedirs() sometimes fails on Emscripten
3 participants
@hoodmane @freakboy3742 @bedevere-bot