gh-127146: Emscripten: Fix test_open_undecodable_uri by setting -sTEXTDECODER=2
#136624
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DER=2` This removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
hoodmane
changed the title
-sTEXTDECODER=2-sTEXTDECODER=2
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 358e0a3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136624%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742
approved these changes
Jul 13, 2025
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2025
… `-sTEXTDECODER=2` (pythonGH-136624) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690. (cherry picked from commit 283b050) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
GH-136631 is a backport of this pull request to the 3.14 branch. |
freakboy3742
pushed a commit
that referenced
this pull request
Jul 14, 2025
…g `-sTEXTDECODER=2` (GH-136624) (#136631) Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690. (cherry picked from commit 283b050) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
hoodmane
added a commit
to hoodmane/cpython
that referenced
this pull request
Jul 16, 2025
…nymore This might have been fixed by pythongh-136624, or by some Emscripten change. In any case, it no longer seems to be needed.
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jul 16, 2025
This makes the code smaller and gets rid of a buggy code path. We switched to this upstream to fix a test: see python/cpython#136624.
freakboy3742
pushed a commit
that referenced
this pull request
Jul 16, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2025
…nymore (pythonGH-136707) This might have been fixed by pythongh-136624, or by some Emscripten change. In any case, it no longer seems to be needed. (cherry picked from commit dcd27aa) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.