Skip to content

gh-136264: Fix PEP-739 build-details generation with relative-paths #136265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Jul 4, 2025

there were two issues with the make_paths_relative implementation:

  1. for top-level entries (i.e. base_interpreter), the parent is "", leading to the part loop to set the container to the non-existent top-level "" key, which becomes {} because it's a defaultdict
  2. for dotted-entries that don't exist in the data, current_path ends up being {}, again, because it's a defaultdict

this PR proposes one (granted, somewhat sus) way to fix it, by:

  1. checking the truthyness of part before indexing into the container (fixing the first issue)
  2. explicitly raising the KeyError when it would have been otherwise raised by a non-defaultdict dict (fixing the second issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant