Skip to content

gh-136193: Improve TypeError msg when comparing two SimpleNamespaces #136195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 2, 2025

Copy link
Contributor

@efimov-mikhail efimov-mikhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm on renaming test to test_richcompare_unsupported.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@sobolevn
Copy link
Member Author

sobolevn commented Jul 2, 2025

We usually don't backport error message changes, so I won't backport this as well.
In case anyone will need a backport - I am ok with creating one, when there's a clear use-case for it.

@sobolevn sobolevn merged commit ab7196a into python:main Jul 2, 2025
44 checks passed
@gold24kETH
Copy link

yes i waiting from this

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
…mespace`s (python#136195)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants