Skip to content

gh-133244: TPen.pensize raises TurtleGraphicsError if called with a negative number #135268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

gh-133244: TPen.pensize raises TurtleGraphicsError if called with a negative number #135268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6521268
gh-106320: Remove private _PyInterpreterState functions (#106335)
vstinner Jul 2, 2023
7890388
Doc: minor change
adorilson Dec 30, 2023
50763c4
Revert "Doc: minor change"
adorilson Mar 25, 2024
558d97f
gh-133244: Add TPen.pensize tests
adorilson Jun 8, 2025
08c5c48
gh-133244 TPen.pensize raises TurtleGraphicsError if called with a ne…
adorilson Jun 8, 2025
130e36d
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 9, 2025
f021b16
gh-133244: Replace 'it was' by 'but got' in error message
adorilson Jun 9, 2025
952ec27
gh-133244: Update news about TPen.pensize
adorilson Jun 9, 2025
132b82d
gh-133244: Update TPen.pensize doc (turtle module)
adorilson Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Doc/library/turtle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,8 @@

:param width: a positive number

:raises TurtleGraphicsError: If *width* is less than zero.

Set the line thickness to *width* or return it. If resizemode is set to
"auto" and turtleshape is a polygon, that polygon is drawn with the same line
thickness. If no argument is given, the current pensize is returned.
Expand All @@ -1090,6 +1092,9 @@
1
>>> turtle.pensize(10) # from here on lines of width 10 are drawn

.. versionchanged:: next
Raise :exc:`TurtleGraphicsError` if *width* is less than zero.

Check warning on line 1096 in Doc/library/turtle.rst

View workflow job for this annotation

GitHub Actions / Docs / Docs 

py:exc reference target not found: TurtleGraphicsError [ref.exc]


.. function:: pen(pen=None, **pendict)

Expand Down
19 changes: 19 additions & 0 deletions Lib/test/test_turtle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,25 @@ def test_teleport(self):
tpen.teleport(-100, -100, fill_gap=fill_gap_value)
self.assertTrue(tpen.isdown())

def test_pensize_with_positive_numbers(self):
tpen = turtle.TPen()

tpen.pensize(42)
self.assertEqual(42, tpen.pensize())

def test_pensize_with_nonpositive_numbers(self):
tpen = turtle.TPen()

tpen.pensize(0)
self.assertEqual(0, tpen.pensize())

width = -1
msg = f"width argument must be a positive number, but got {width}."
with self.assertRaisesRegex(turtle.TurtleGraphicsError, re.escape(msg)):
tpen.pensize(width)

self.assertEqual(0, tpen.pensize())


class TestTurtleScreen(unittest.TestCase):
def test_save_raises_if_wrong_extension(self) -> None:
Expand Down
6 changes: 5 additions & 1 deletion Lib/turtle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2141,7 +2141,11 @@ def pensize(self, width=None):
"""
if width is None:
return self._pensize
self.pen(pensize=width)
elif width < 0:
msg = f"width argument must be a positive number, but got {width}."
raise TurtleGraphicsError(msg)
else:
self.pen(pensize=width)


def penup(self):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-06-09-08-11-47.gh-issue-133244.GINMl-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:meth:`!turtle.TPen.pensize` raises an exception if called with a negative *width* argument.
Loading