gh-130595: Keep traceback alive for WITH_EXCEPT_START #130562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
approved these changes
Feb 26, 2025
DinoV
changed the title
DinoV
added
needs backport to 3.12
|
Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @DinoV, I could not cleanly backport this to |
|
Sorry, @DinoV, I could not cleanly backport this to |
|
|
|
|
|
|
| assert(PyStackRef_LongCheck(lasti)); | ||
| (void)lasti; // Shut up compiler warning if asserts are off | ||
| PyObject *stack[5] = {NULL, PyStackRef_AsPyObjectBorrow(exit_self), exc, val_o, tb}; | ||
| int has_self = !PyStackRef_IsNull(exit_self); | ||
| PyObject *res_o = PyObject_Vectorcall(exit_func_o, stack + 2 - has_self, | ||
| (3 + has_self) | PY_VECTORCALL_ARGUMENTS_OFFSET, NULL); | ||
| ERROR_IF(res_o == NULL, error); | ||
| Py_XDECREF(original_tb); |
There was a problem hiding this comment.
This should be moved up to before the ERROR_IF
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…30562) Keep traceback alive for WITH_EXCEPT_START
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WITH_EXCEPT_START opcode is getting the traceback from the exception object and then passing it down via a vectorcall, but only after decref'ing the traceback.
But the exception object can have the only reference to the traceback. If the receiver of the traceback does something to cause the exception's trace back to be replaced, then uses the traceback, they access dangling pointer. The traceback shouldn't solely be kept alive by the exception object which can be mutated.