Skip to content

GH-107463: Moved most extension modules to the pythoncore project file #107478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

AraHaan
Copy link
Contributor

@AraHaan AraHaan commented Jul 31, 2023

For this I had to start with making the changes to the 3.11 branch, then a few additional changes in the 3.12 branch, before finally adding some minor fixups in the main branch due to the following:

  • 3.12 added the _wmi c++ extension module (C++ 20 standard)
  • 3.13 removed the _msi c extension module and project file (which means needing to remove it from config.c and from pythoncore.vcxproj when I open pr to main)

Note: I lack the ability to edit the build scripts for linux and macos building so someone would have to assist with bringing these changes to those scripts as well.

Also I would recommend making changes starting with whichever one is easier (the 3.11 version, the 3.12 version, or this version from main (3.13)).

@rhettinger rhettinger removed their request for review August 3, 2023 14:50
@AA-Turner
Copy link
Member

I'm going to close this PR until there's consensus for this change on the linked issue (#107463). Feel free to continue experimenting on your fork!

A

@AA-Turner AA-Turner closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants