-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Description
First, this module defines a bin function that is not present in the documentation. Such a method should be documented or made private. Indeed, it would feel weird for a user to use from enum import *
and have the standard bin() function overriden.
The commit that introcuced this function is #7aaeb2a
This function only appears to have be used by the commit for Flag.missing, where it's present two or three times
Thus, i guess this function was created for internal code refactorisation.
This is a normal use for a function. However, a function used for this should not be available to an importer of enum. It should especially not be able to cause problems in the code of the importer.
I suggest renaming the function _bin and replacing existing occurences of call to this function by a call to its new name.
Broadlier speaking, I do not see a valid reason for the import of builtins in the enum module, because it is bad practice: the only use case is builtin functions having been redefined inside the code, which is a source of confusions and errors and therefore not good practice.
This probably means they're other problems like this in the enum module. One I found is the decorator @property
. I did not investigated this one further.
Metadata
Metadata
Assignees
Labels
Projects
Status