`traverse_module_state` can return `int`, do not use `(void)` for it

# Bug report

`traverse_module_state` can in theory return non-zero code:

https://github.com/python/cpython/blob/0d9d48959e050b66cb37a333940ebf4dc2a74e15/Modules/_interpchannelsmodule.c#L283-L302

because `PY_VISIT` can return it: https://github.com/python/cpython/blob/0d9d48959e050b66cb37a333940ebf4dc2a74e15/Include/objimpl.h#L193-L200

So, using it like this: https://github.com/python/cpython/blob/0d9d48959e050b66cb37a333940ebf4dc2a74e15/Modules/_interpchannelsmodule.c#L3627-L3629

Is also not really correct. I will send a PR with the fix.


### Linked PRs
* gh-135840
* gh-135918
* gh-135919
* gh-135937
* gh-135939
* gh-135943

	static int
	traverse_module_state(module_state state, visitproc visit, void arg)
	{
	/* external types */
	Py_VISIT(state->send_channel_type);
	Py_VISIT(state->recv_channel_type);

	/* heap types */
	Py_VISIT(state->ChannelInfoType);
	Py_VISIT(state->ChannelIDType);

	/* exceptions */
	Py_VISIT(state->ChannelError);
	Py_VISIT(state->ChannelNotFoundError);
	Py_VISIT(state->ChannelClosedError);
	Py_VISIT(state->ChannelEmptyError);
	Py_VISIT(state->ChannelNotEmptyError);

	return 0;
	}

	#define Py_VISIT(op) \
	do { \
	if (op) { \
	int vret = visit(_PyObject_CAST(op), arg); \
	if (vret) \
	return vret; \
	} \
	} while (0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

`traverse_module_state` can return `int`, do not use `(void)` for it #135839

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	// Now we clear the module state.
	(void)clear_module_state(state);
	return 0;

Uh oh!

traverse_module_state can return int, do not use (void) for it #135839

Description

Bug report

Linked PRs

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`traverse_module_state` can return `int`, do not use `(void)` for it #135839