-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Closed
Labels
Description
I've been working on adding support for 3.13
to mypyc. After updating the codebase, there are still some functions left we depend on which are now private after #106320. Would it make sense to export these again? That would make adopting 3.13
a bit easier. /CC @vstinner
_PyBytes_Join
defined inpycore_bytesobject.h
_PyObject_CallMethodIdObjArgs
defined inpycore_call.h
_PyType_CalculateMetaclass
defined inpycore_object.h
_PyUnicode_EQ
defined inpycore_unicodeobject.h
_PyUnicode_FastCopyCharacters
defined inpycore_unicodeobject.h
(this could be replaced withPyUnicode_CopyCharacters
but it's used in a simplified copy of_PyUnicode_JoinArray
which also uses_PyUnicode_FastCopyCharacters
).
Other functions include these two. However, as they are inlined, it isn't a problem to include them.
_PyObject_CallMethodIdNoArgs
and_PyObject_CallMethodIdOneArg
defined inpycore_call.h
It would be fine to keep all of them in internal/pycore_*
and just add PyAPI_FUNC
.
/CC @hauntsaninja