-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
Closed as not planned
Labels
testsTests in the Lib/test dirTests in the Lib/test dir
Description
It is better to not import from one test in other tests, I propose adding a utils
module for common types / helpers.
Originally posted by @sobolevn in #111624 (comment)
For example:
cpython/Lib/test/test_complex.py
Lines 446 to 450 in 93206d1
class float2: | |
def __init__(self, value): | |
self.value = value | |
def __float__(self): | |
return self.value |
and
cpython/Lib/test/test_capi/test_getargs.py
Lines 102 to 104 in 93206d1
class Float: | |
def __float__(self): | |
return 4.25 |
cpython/Lib/test/test_capi/test_getargs.py
Lines 113 to 123 in 93206d1
class BadFloat: | |
def __float__(self): | |
return 687 | |
class BadFloat2: | |
def __float__(self): | |
return FloatSubclass(4.25) | |
class BadFloat3(float): | |
def __float__(self): | |
return FloatSubclass(4.25) |
we could unify to:
class FloatLike:
def __init__(self, value):
self.value = value
def __float__(self):
return self.value
Such support classes now scattered e.g. in Lib/test_float.py
and in Lib/test_capi/test_getargs.py
.
Linked PRs
Metadata
Metadata
Assignees
Labels
testsTests in the Lib/test dirTests in the Lib/test dir