Skip to content

feat: use ghcr image instead of docker #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat: use ghcr image instead of docker #533

wants to merge 4 commits into from

Conversation

zMynxx
Copy link
Contributor

@zMynxx zMynxx commented Apr 21, 2025

Avoid a common issue 429 too many requests due to the super-low DockerHub unauthenticated pulls limit.
Use GHCR instead.

@github-actions GitHub Actions
Copy link

End-to-end public repo

Admin commands cheatsheet:

  • /e2e (in approved PR review body): Trigger end-to-end tests on external contributions
  • /invite (in comment): Invite the author & admins to the end-to-end private repo

@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@zMynxx zMynxx mentioned this pull request Apr 21, 2025
Closed
@ellisvalentiner
Copy link
Contributor

Any updates on this? It looks like the CI failure is unrelated.

@zMynxx
Copy link
Contributor Author

zMynxx commented May 4, 2025

Any updates on this? It looks like the CI failure is unrelated.

Yeah the CI failure has nothing to do with it.
Other than that waiting on @ewjoachim to move forward with this 😄

ewjoachim
ewjoachim reviewed May 5, 2025
View reviewed changes
README.md
Comment on lines +620 to +623
The Dockerfile used by this image can have both registeries as sources:
- ewjoachim/python-coverage-comment-action-base:v6
- ghcr.io/py-cov-action/python-coverage-comment-action-base:v6
Take your pick according to your needs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear how users could change something there, I believe the choice we make is something everyone has to live with, no ?

Also, better not hardcode v6 in too many places !

ewjoachim
ewjoachim approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ! I left a single comment but I think we can merge all other files :)

@ewjoachim
Copy link
Member

I hope it's ok with you, but as I'll be needing this quite soon, I'm making my branch with your commits, I'll leave authorship and link to here. Thank you a ton for your work here !

@ewjoachim ewjoachim mentioned this pull request May 5, 2025
Merged
@ewjoachim
Copy link
Member

Closing in favor of #540 but by all means, don't take it as a way to say your contribution wasn't appreciated ! It was, it's just GitHub's way of collaborating on forks is limited :)

@ewjoachim ewjoachim closed this May 5, 2025
@ewjoachim
Copy link
Member

Now released, thanks a lot! https://github.com/py-cov-action/python-coverage-comment-action/releases/tag/v3.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zMynxx @ellisvalentiner @ewjoachim