Skip to content

Make push method configurable #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

dgl
Copy link
Contributor

@dgl dgl commented May 28, 2021

Previously MetricPusher was hardcoded to make a POST request.
Pushgateway in Prometheus supports POST or PUT, with a different
meaning.

This keeps the current default (which unfortunately is the opposite of
some other implementations) of adding data (using POST) but makes it
possible to replace data (using PUT).

Previously MetricPusher was hardcoded to make a POST request.
Pushgateway in Prometheus supports POST or PUT, with a different
meaning.

This keeps the current default (which unfortunately is the opposite of
some other implementations) of adding data (using POST) but makes it
possible to replace data (using PUT).
@Catbuttes
Copy link

This is something that would be extremely useful for me as well if it could be merged.

@sandersaares
Copy link
Member

Sounds reasonable. Thank you for the contribution!

@sandersaares sandersaares merged commit 76fc922 into prometheus-net:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants