-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Cut v1.23.0-rc.0 #1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut v1.23.0-rc.0 #1837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some minor changes.
CHANGELOG.md
Outdated
* [ENHANCEMENT] exp/api: Bubble up status code from writeResponse #1823 | ||
* [ENHANCEMENT] Update runtime metrics for Go v1.23 and v1.24 #1833 | ||
* [BUGFIX] fix: client prompt return on context cancellation #1729 | ||
* [BUGIFX] Fix errNotImplemented reference #1835 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's double check if this is a bug exists in the previous released version. If it is not no need to mention it in the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it wasn't a bug in the previous version, good catch!
Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>
7fab953
to
5ff80d9
Compare
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com> Signed-off-by: Arianna Vespri <36129782+vesari@users.noreply.github.com>
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com> Signed-off-by: Arianna Vespri <36129782+vesari@users.noreply.github.com>
Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>
@kakkoyun I realized in the meantime that this is supposed to be a release candidate, so I changed the changelog and version files accordingly. Is my assumption correct? |
Cut v1.23.0-rc.0