feat: quoteStyle option #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
requested review from
michael-ciniawsky,
mrmlnc,
Scrum and
voischev
as code owners
SukkaW
commented
Nov 18, 2020
| return html(tree); | ||
|
|
||
| /** @private */ | ||
| function isSingleTag(tag) { | ||
| if (singleRegExp.length > 0) { | ||
| return singleRegExp.some(reg => reg.test(tag)) | ||
| return singleRegExp.some(reg => reg.test(tag)); |
There was a problem hiding this comment.
The ; is added by xo --fix.
SukkaW
commented
Nov 18, 2020
Comment on lines
+157
to
+160
| node === null || | ||
| node === false || | ||
| node.length === 0 || | ||
| Number.isNaN(node)) { |
There was a problem hiding this comment.
The indent is changed by xo --fix.
Scrum
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable ChangesquoteStyleoption enables user specify whether double quote or single quote should be used.It is also an alternative to
replaceQuoteoption.Commit Message Summary (CHANGELOG)TypeSemVerMinor. Since the PR introduces a new feature, but the default value for the new option has the same behavior as the current version (No breaking changes).
IssuesAn alternative fix for posthtml/htmlnano#41
Checklist