Skip to content

NodeApp.make_empty must pass os_ops and port_manager to nodes #265

New issue
New issue
Closed
#278
Closed
NodeApp.make_empty must pass os_ops and port_manager to nodes#265
#278
Labels
bugenhancement
@dmitry-lipetsk

Description

@dmitry-lipetsk
dmitry-lipetsk
opened on Jun 21, 2025

Constructor of NodeApp obtains os_ops but does not pass it to a new node. See this code:

testgres/testgres/node.py

Lines 2335 to 2346 in 44d61c2

self.os_ops = os_ops
def make_empty(
self,
base_dir=None,
port=None,
bin_dir=None):
real_base_dir = os.path.join(self.test_path, base_dir)
self.os_ops.rmdirs(real_base_dir, ignore_errors=True)
self.os_ops.makedirs(real_base_dir)
node = PostgresNode(base_dir=real_base_dir, port=port, bin_dir=bin_dir)

Also, the constructor of NodeApp can get port_manager object and pass it to the new nodes in make_empty, too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugenhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions