[PBCKP-236] [skip] removed unnecessary TODOs

Ivan Lazarev · Ivan Lazarev · commit b2091cd2c277 · 2022-09-16T05:51:11.000+03:00
diff --git a/src/utils/file.c b/src/utils/file.c
@@ -268,7 +268,6 @@ fio_write_all(int fd, void const* buf, size_t size)
 	return offs;
 }
 
-//TODO REVIEW XXX move to remote.c????
 /* Get version of remote agent */
 void
 fio_get_agent_version(int* protocol, char* payload_buf, size_t payload_buf_size)
@@ -3217,7 +3216,6 @@ fio_delete_impl(mode_t mode, char *buf)
 }
 
 /* Execute commands at remote host */
-//TODO REVIEW XXX move to remote.c?
 void
 fio_communicate(int in, int out)
 {
diff --git a/src/utils/remote.c b/src/utils/remote.c
@@ -117,9 +117,6 @@ bool launch_agent(void)
 	int infd[2];
 	int errfd[2];
 	int agent_version;
-	//TODO REVIEW XXX review buf_size
-	int payload_buf_size = 1024 * 8;
-	char payload_buf[payload_buf_size];
 
 	ssh_argc = 0;
 #ifdef WIN32
@@ -241,10 +238,13 @@ bool launch_agent(void)
 		fio_redirect(infd[0], outfd[1], errfd[0]); /* write to stdout */
 	}
 
-	/* Make sure that remote agent has the same version, fork and other features to be binary compatible
-	 */
-	fio_get_agent_version(&agent_version, payload_buf, payload_buf_size);
-	check_remote_agent_compatibility(agent_version, payload_buf, payload_buf_size);
+
+	/* Make sure that remote agent has the same version, fork and other features to be binary compatible */
+	{
+		char payload_buf[1024];
+		fio_get_agent_version(&agent_version, payload_buf, sizeof payload_buf);
+		check_remote_agent_compatibility(agent_version, payload_buf, sizeof payload_buf);
+	}
 
 	return true;
 }
@@ -268,7 +268,7 @@ size_t prepare_compatibility_str(char* compatibility_buf, size_t compatibility_b
 	char* compatibility_params[] = {
 		COMPATIBILITY_VAL_STR(PG_MAJORVERSION),
 #ifdef PGPRO_EDN
-		//TODO REVIEW can use edition.h/extract_pgpro_edition()
+		//TODO REVIEW can use edition.h/extract_pgpro_edition() or similar
 		COMPATIBILITY_VAL_STR(PGPRO_EDN),
 #endif
 		//TODO REVIEW remove? no difference between 32/64 in global/pg_control.

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,6 @@ fio_write_all(int fd, void const* buf, size_t size)`
`268`	`268`	`return offs;`
`269`	`269`	`}`
`270`	`270`
`271`		`-//TODO REVIEW XXX move to remote.c????`
`272`	`271`	`/* Get version of remote agent */`
`273`	`272`	`void`
`274`	`273`	`fio_get_agent_version(int* protocol, char* payload_buf, size_t payload_buf_size)`
`@@ -3217,7 +3216,6 @@ fio_delete_impl(mode_t mode, char *buf)`
`3217`	`3216`	`}`
`3218`	`3217`
`3219`	`3218`	`/* Execute commands at remote host */`
`3220`		`-//TODO REVIEW XXX move to remote.c?`
`3221`	`3219`	`void`
`3222`	`3220`	`fio_communicate(int in, int out)`
`3223`	`3221`	`{`