Avoid memory leak on deletion from uint64 list

danolivo · danolivo · commit 4ebda34af3cc · 2022-09-07T09:47:53.000+05:00
diff --git a/hash.c b/hash.c
@@ -131,6 +131,11 @@ lappend_uint64(List *list, uint64 datum)
 	return list;
 }
 
+/*
+ * Remove element from a list and free the memory which was allocated to it.
+ * Looks unconventional, but we unconventionally allocate memory on append, so
+ * it maybe ok.
+ */
 List *
 ldelete_uint64(List *list, uint64 datum)
 {
@@ -140,6 +145,7 @@ ldelete_uint64(List *list, uint64 datum)
 	{
 		if (*((uint64 *)lfirst(cell)) == datum)
 		{
+			pfree(lfirst(cell));
 			list = list_delete_ptr(list, lfirst(cell));
 			return list;
 		}

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,11 @@ lappend_uint64(List *list, uint64 datum)`
`131`	`131`	`return list;`
`132`	`132`	`}`
`133`	`133`
	`134`	`+/*`
	`135`	`+ * Remove element from a list and free the memory which was allocated to it.`
	`136`	`+ * Looks unconventional, but we unconventionally allocate memory on append, so`
	`137`	`+ * it maybe ok.`
	`138`	`+ */`
`134`	`139`	`List *`
`135`	`140`	`ldelete_uint64(List *list, uint64 datum)`
`136`	`141`	`{`
`@@ -140,6 +145,7 @@ ldelete_uint64(List *list, uint64 datum)`
`140`	`145`	`{`
`141`	`146`	`if (((uint64 )lfirst(cell)) == datum)`
`142`	`147`	`{`
	`148`	`+ pfree(lfirst(cell));`
`143`	`149`	`list = list_delete_ptr(list, lfirst(cell));`
`144`	`150`	`return list;`
`145`	`151`	`}`