Skip to content

Commit e89a8e3

Browse files
committed
Fix outdated comment that talked about seek position of WAL file.
Since commit c24dcd0, we have been using pg_pread() to read the WAL file, which doesn't change the seek position (unless we fall back to the implementation in src/port/pread.c). Update comment accordingly. Backpatch-through: 12, where we started to use pg_pread()
1 parent d906d10 commit e89a8e3

File tree

1 file changed

+3
-5
lines changed
  • src/backend/access/transam

1 file changed

+3
-5
lines changed

src/backend/access/transam/xlog.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -801,11 +801,9 @@ static XLogSegNo openLogSegNo = 0;
801801

802802
/*
803803
* These variables are used similarly to the ones above, but for reading
804-
* the XLOG. Note, however, that readOff generally represents the offset
805-
* of the page just read, not the seek position of the FD itself, which
806-
* will be just past that page. readLen indicates how much of the current
807-
* page has been read into readBuf, and readSource indicates where we got
808-
* the currently open file from.
804+
* the XLOG. readOff is the offset of the page just read, readLen
805+
* indicates how much of it has been read into readBuf, and readSource
806+
* indicates where we got the currently open file from.
809807
* Note: we could use Reserve/ReleaseExternalFD to track consumption of
810808
* this FD too; but it doesn't currently seem worthwhile, since the XLOG is
811809
* not read by general-purpose sessions.

0 commit comments

Comments
 (0)