pg_dumpall: Skip global objects with --statistics-only or --no-schema.

jeff-davis · jeff-davis · commit 973caf7291c1 · 2025-07-16T09:57:07.000-07:00
Previously, pg_dumpall would still dump global objects such as roles and tablespaces even when --statistics-only or --no-schema was specified. Since these global objects are treated as schema-level data, they should be skipped in these cases. This commit fixes the issue by ensuring that global objects are not dumped when either --statistics-only or --no-schema is used. Author: Fujii Masao <masao.fujii@oss.nttdata.com> Reviewed-by: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/08129593-6f3c-4fb9-94b7-5aa2eefb99b0@oss.nttdata.com Backpatch-through: 18
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -632,7 +632,7 @@ main(int argc, char *argv[])
 		fprintf(OPF, "SET escape_string_warning = off;\n");
 	fprintf(OPF, "\n");
 
-	if (!data_only)
+	if (!data_only && !statistics_only && !no_schema)
 	{
 		/*
 		 * If asked to --clean, do that first.  We can avoid detailed

Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,7 @@ main(int argc, char *argv[])`
`632`	`632`	`fprintf(OPF, "SET escape_string_warning = off;\n");`
`633`	`633`	`fprintf(OPF, "\n");`
`634`	`634`
`635`		`- if (!data_only)`
	`635`	`+ if (!data_only && !statistics_only && !no_schema)`
`636`	`636`	`{`
`637`	`637`	`/*`
`638`	`638`	`* If asked to --clean, do that first. We can avoid detailed`