Skip to content

Commit 19179db

Browse files
committed
doc: Inform about aminsertcleanup optional NULLness
This index AM callback has been introduced in c1ec02b and it is optional, currently only being used by BRIN. Optional callbacks are documented with NULL as possible value in amapi.h and indexam.sgml, but this callback has missed this part of the description. Reported-by: Peter Smith <smithpb2250@gmail.com> Reviewed-by: Japin Li <japinli@hotmail.com> Discussion: https://postgr.es/m/CAHut+PvgYcPmPDi1YdHMJY5upnyGRpc0N8pk1xNB11xDSBwNog@mail.gmail.com Backpatch-through: 17
1 parent 112faf1 commit 19179db

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

doc/src/sgml/indexam.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ typedef struct IndexAmRoutine
147147
ambuild_function ambuild;
148148
ambuildempty_function ambuildempty;
149149
aminsert_function aminsert;
150-
aminsertcleanup_function aminsertcleanup;
150+
aminsertcleanup_function aminsertcleanup; /* can be NULL */
151151
ambulkdelete_function ambulkdelete;
152152
amvacuumcleanup_function amvacuumcleanup;
153153
amcanreturn_function amcanreturn; /* can be NULL */

src/include/access/amapi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ typedef struct IndexAmRoutine
293293
ambuild_function ambuild;
294294
ambuildempty_function ambuildempty;
295295
aminsert_function aminsert;
296-
aminsertcleanup_function aminsertcleanup;
296+
aminsertcleanup_function aminsertcleanup; /* can be NULL */
297297
ambulkdelete_function ambulkdelete;
298298
amvacuumcleanup_function amvacuumcleanup;
299299
amcanreturn_function amcanreturn; /* can be NULL */

0 commit comments

Comments
 (0)