Fix return value of visibilitymap_get_status().

nathan-bossart · nathan-bossart · commit 15d33eb1924c · 2025-07-24T10:13:45.000-05:00
This function is declared as returning a uint8, but it returns a bool in one code path. To fix, return (uint8) 0 instead of false there. This should behave exactly the same as before, but it might prevent future compiler complaints. Oversight in commit a892234. Author: Julien Rouhaud <rjuju123@gmail.com> Discussion: https://postgr.es/m/aIHluT2isN58jqHV%40jrouhaud
diff --git a/src/backend/access/heap/visibilitymap.c b/src/backend/access/heap/visibilitymap.c
@@ -364,7 +364,7 @@ visibilitymap_get_status(Relation rel, BlockNumber heapBlk, Buffer *vmbuf)
 	{
 		*vmbuf = vm_readbuf(rel, mapBlock, false);
 		if (!BufferIsValid(*vmbuf))
-			return false;
+			return (uint8) 0;
 	}
 
 	map = PageGetContents(BufferGetPage(*vmbuf));

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ visibilitymap_get_status(Relation rel, BlockNumber heapBlk, Buffer *vmbuf)`
`364`	`364`	`{`
`365`	`365`	`*vmbuf = vm_readbuf(rel, mapBlock, false);`
`366`	`366`	`if (!BufferIsValid(*vmbuf))`
`367`		`- return false;`
	`367`	`+ return (uint8) 0;`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`map = PageGetContents(BufferGetPage(*vmbuf));`