Skip to content

Please don't download binary into user's home directory in build.rs #216

@yshui

Description

@yshui

Here: https://github.com/plotly/plotly.rs/blob/main/plotly_kaleido/build.rs

I think this is unhygienic. It is surprising to me that building something would cause files to be added to my home directory. This also breaks when building in a sandboxed environment (which is how I found out).

Plus, it is downloading something that is not strictly needed for the build process. And it is also not going to achieve what I assume is your goal. What if I build on one machine then ship the binary to run somewhere else?

Metadata

Metadata

Assignees

Labels

KaleidoIssue related to Kaleido dependency

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions