Skip to content

fix: Add method to check for WebKit WebView user agent string #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: Add method to check for WebKit WebView user agent string #7479

wants to merge 3 commits into from

Conversation

camdecoster
Copy link
Contributor

@camdecoster camdecoster commented Jul 18, 2025 •
edited
Loading

Description

Adds utility method to check for WebKit WebView using user agent string. Closes #7476.

Changes

  • Adds utility method
  • Adds tests for user agent related methods

Testing

  • TBD

Notes

  • This change is necessary to enable logic when the library is being used in Plotly Studio
  • The regex test returned the proper result for everything that I threw at it, but let me know if you find a breaking string
  • An alternative (though narrower) approach is to test if the user is on a Mac and in a Tauri webview

@camdecoster camdecoster changed the title Cam/7476/add-iswebkitwebview-check feat: Add method to check for WebKit WebView user agent string Jul 18, 2025
@camdecoster camdecoster changed the title feat: Add method to check for WebKit WebView user agent string fix: Add method to check for WebKit WebView user agent string Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isSafari regex check doesn't catch WebKit webview in Tauri browser
1 participant
@camdecoster