ext/intl: reducing raw pointer usage in C++ part, using smart ones in… #19179
+22
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Jul 18, 2025
| goto cleanup; | ||
| } | ||
|
|
||
| object_init_ex(return_value, GregorianCalendar_ce_ptr); | ||
| co = Z_INTL_CALENDAR_P(return_value); | ||
| co->ucal = gcal; | ||
| // TODO: trying to get passed the ownership change step |
There was a problem hiding this comment.
if I can, changing the structure so I do not need to pass the ownership.
There was a problem hiding this comment.
I see. I suppose that would be preferable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stead.