GH-19153: Validate #[\Attribute] targets
#19154
Open
+71
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow #[\Attribute] on traits, interfaces, enums, or abstract classes.
|
Targeting master for the same reason as #15733 did - this adds a new error where previously there wasn't one until you tried to make use of the attribute, at which point ReflectionAttribute::newInstance() would complain that you can't instantiate a trait/enum/interface/abstract class |
iluuu1994
reviewed
Jul 17, 2025
| zend_attribute *attr, uint32_t target, zend_class_entry *scope) | ||
| { | ||
| const char *msg = NULL; | ||
| if (scope->ce_flags & ZEND_ACC_TRAIT) { |
There was a problem hiding this comment.
Nit: You can use zend_get_object_type_case() for most of these.
There was a problem hiding this comment.
But that will return "Class" (or "class") if its not a trait/interface/enum, and so
- we still need to check if it is a trait/interface/enum
- we still need to check if it is an abstract class
it would look something like
const char *type = NULL;
if (scope->ce_flags & (ZEND_ACC_TRAIT|ZEND_ACC_INTERFACE|ZEND_ACC_ENUM)) {
type = zend_get_object_type_case(scope, false);
} else if (scope->ce_flags & ZEND_ACC_EXPLICIT_ABSTRACT_CLASS) {
type = "abstract class";
}
if (type != NULL) {
zend_error_noreturn(E_ERROR, "Cannot apply #[Attribute] to %s %s", type, ZSTR_VAL(scope->name));
}and I don't think that that is more readable
There was a problem hiding this comment.
It's more about keeping the wording consistent, but I'm ok either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow
#[\Attribute]on traits, interfaces, enums, or abstract classes.