K8SPG-600: Fix failed backup status #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pooknull
changed the title
egegunes
previously approved these changes
Jun 24, 2024
inelpandzic
previously approved these changes
Jun 24, 2024
egegunes
approved these changes
Jun 25, 2024
commit: 066cdc9 |
hors
approved these changes
Jun 25, 2024
inelpandzic
approved these changes
Jun 25, 2024
ptankov
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Fix failed backup status * fix lint * fix fmt * fix regression and status update
hors
added a commit
that referenced
this pull request
Jun 28, 2024
* K8SPG-597 Update images and versions for 2.4.0 release (#819) * K8SPG-597 Update images and versions for 2.4.0 release * supply minor tag versions * update the image in upgrade.yaml * K8SPG-600: Fix failed backup status (#820) * Fix failed backup status * fix lint * fix fmt * fix regression and status update * K8SPG-518: Fix WAL archiving on Openshift (#823) * K8SPG-597 Fixing test case upgrade-minor to work with postures images which have minor numbers in the image name (#821) * We now have env var PG_VER so no need to calculate the version from the image name, also, the calculation was buggy when the version contains a dot and a minor number, e.g. 16.3 * Refactor upgrade-cluster.yaml to use PG_VER environment variable instead of calculating version from image name * K8SPG-597 - Update monitoring test (#824) * K8SPG-254: Fix major upgrade on Openshift (#826) --------- Co-authored-by: Andrii Dema <a.dema@jazzserve.com> Co-authored-by: Ege Güneş <ege.gunes@percona.com> Co-authored-by: Tomislav Plavcic <tomislav.plavcic@percona.com> Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-600
DESCRIPTION
Problem:
If the user has the wrong
pgbackrestcredentials, the failed backup doesn't get thefailedstate in thepg-backup.status..Reason:
When incorrect
pgbackrestcredentials are used, the pg cluster reconcile fails, which stops the process of updating crunchy'spostgresclusterresource. It is necessary to delete backup annotations from crunchy's resource, and this problem doesn't allow it to continue.Solution:
Don't stop the reconcile process with the
pgbackresterror. Log the error message instead. Also, the operator should avoid trying to usepgbackrestwhen the backup job has failed.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability