Skip to content

K8SPG-493: disable scheduled backups when .spec.pause: true #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

K8SPG-493: disable scheduled backups when .spec.pause: true #642

merged 1 commit into from
Jan 22, 2024

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Jan 19, 2024 •
edited by jira bot
Loading

K8SPG-493 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-493

DESCRIPTION

Problem:
When .spec.pause is set to true in PerconaPGCluster, operator creates scheduled backup

Solution:
Check if the cluster is paused before trying to create the scheduled backup.

Also, this PR reduces the chances of pg-backup stuck in Starting state, which is caused by crunchy reconcile not triggered by pg-backup update. This is done by adding a watch function to the crunchy controller.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
demand-backup passed
init-deploy passed
monitoring passed
operator-self-healing passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
telemetry-transfer passed
upgrade-minor passed
users passed
We run 12 out of 12

commit: 62dd837
image: perconalab/percona-postgresql-operator:PR-642-62dd837f0

@hors hors merged commit a6e8921 into main Jan 22, 2024
@hors hors deleted the dev/K8SPG-493-fix branch January 22, 2024 07:00
tplavcic pushed a commit that referenced this pull request Jan 22, 2024
@pooknull @tplavcic
K8SPG-493: disable scheduled backups when .spec.pause: true (#642)
8253f68 
https://perconadev.atlassian.net/browse/K8SPG-493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tplavcic tplavcic tplavcic approved these changes

@hors hors hors approved these changes

@egegunes egegunes egegunes approved these changes

@inelpandzic inelpandzic Awaiting requested review from inelpandzic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pooknull @JNKPercona @tplavcic @hors @egegunes