Fix for Next 15.4+ #928
Merged
Fix for Next 15.4+ #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b40c74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
changed the title
|
Good job on this Nico! I tested that the rewrites will have the correct Is there any possibility that we might fix that the |
sommeeeer
reviewed
Jul 18, 2025
| @@ -266,6 +267,12 @@ async function processRequest( | |||
| //#endOverride | |||
|
|
|||
| // Next Server | |||
| // TODO: only enable this on Next 15.4+ | |||
| const reqUrl = new URL(routingResult.initialURL); | |||
There was a problem hiding this comment.
We compute initialURL above on L242
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
khuezy
reviewed
Jul 21, 2025
|
Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to a canary version for now (we need to wait for 15.4.2)
Enable local execution of some examples (first step to run e2e test without deploying)
And fix the page router functionality. This one needs additional testing and be restricted to versions above 15.4.2.
All e2e works on this PR.
It should also close #848 (again needs additional testing)