Skip to content

Realtime: forward exceptions from transport layer #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Realtime: forward exceptions from transport layer #1107

merged 2 commits into from
Jul 14, 2025

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Jul 14, 2025 •
edited
Loading

The model listens to websocket events in a separate task, and the session receives those events in on_event. So if there's e.g. a websocket or json exception, it's silently dropped. Similar to the streaming text agents, we should:

  • capture exceptions separately
  • raise them in async for event in session loop.

Added tests to verify.

This was referenced Jul 14, 2025
Merged
Merged
@rm-openai rm-openai requested a review from seratch July 14, 2025 17:42
This was referenced Jul 14, 2025
Merged
Merged
rm-openai added a commit that referenced this pull request Jul 14, 2025
@rm-openai
Realtime: run guardrails without blockign event loop (#1104)
3d66226 
Guardrails were blocking the event loop. Now, they run as a separate
task.




---
[//]: # (BEGIN SAPLING FOOTER)
* #1112
* #1111
* #1107
* #1106
* __->__ #1104
rm-openai added a commit that referenced this pull request Jul 14, 2025
@rm-openai
Run make format (#1106)
bd988dc 
cleanup





---
[//]: # (BEGIN SAPLING FOOTER)
* #1112
* #1111
* #1107
* __->__ #1106
Base automatically changed from rm/pr1106 to main July 14, 2025 21:35
@rm-openai rm-openai merged commit af4cef3 into main Jul 14, 2025
15 checks passed
@rm-openai rm-openai deleted the rm/pr1107 branch July 14, 2025 21:53
@seratch seratch added enhancement New feature or request feature:realtime labels Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhills20 jhills20 jhills20 approved these changes

@seratch seratch Awaiting requested review from seratch

Assignees

@pakrym-oai pakrym-oai

Labels
enhancement New feature or request feature:realtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rm-openai @jhills20 @seratch @pakrym-oai