Skip to content

Permit to override default OTLP exporter headers #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jun 12, 2025

Description

We would like being able to use a specific user agent on our distro in order to discriminate OTLP traffic from our distro and upstream. At the moment this is not possible because exporter always override the passed headers with the default ones. Currently the HTTP exporters sets content-type and user-agent while the grpc ones just user-agent.

It was pointed out that we may not even set grpc headers correctly but on the backend we get them just fine.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner June 12, 2025 13:42
@xrmx xrmx changed the title Permit to override exporter headers Permit to override default OTLP exporter headers Jun 12, 2025
@xrmx xrmx self-assigned this Jun 12, 2025
Copy link
Contributor Author

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if instead of that we should make the default headers substituted via an entry point (or even make them a param for the init functions called by _initialize_components) so that we have a different mechanism that the user cannot easily override. This is because otherwise users setting OTEL_EXPORTER_OTLP_HEADERS will always override what distro sets.

@xrmx xrmx marked this pull request as draft June 24, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants