Skip to content

Commit fd86fd1

Browse files
modified the return from both main and helper. (keon#886)
It looks like there is no need to create a copy, we can replace the new elements inplace.
1 parent 2a129ba commit fd86fd1

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

algorithms/sort/merge_sort.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ def merge_sort(arr):
1010
left, right = merge_sort(arr[:mid]), merge_sort(arr[mid:])
1111

1212
# Merge each side together
13-
return merge(left, right, arr.copy())
13+
# return merge(left, right, arr.copy()) # changed, no need to copy, mutate inplace.
14+
merge(left,right,arr)
15+
return arr
1416

1517

1618
def merge(left, right, merged):
@@ -35,4 +37,4 @@ def merge(left, right, merged):
3537
merged[left_cursor + right_cursor] = right[right_cursor]
3638

3739
# Return result
38-
return merged
40+
# return merged # do not return anything, as it is replacing inplace.

0 commit comments

Comments
 (0)