Skip to content

MAINT: Options to catch more issues reported by pytest #28983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 16, 2025

Apply Scientific Python Development Guide suggestions PP306, PP307, PP308. Skip PP305 for now.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented May 16, 2025

Not sure how to retrieve detailed logs to fix these issues:

FAILED numpy/_core/tests/test_multiarray.py::TestBool::test_cast_from_unicode
FAILED numpy/_core/tests/test_multiarray.py::TestBool::test_cast_from_bytes
FAILED numpy/_core/tests/test_numeric.py::TestClip::test_NaT_propagation[arr0-amin0-amax0]
FAILED numpy/lib/tests/test_arraypad.py::TestLinearRamp::test_object_array
FAILED numpy/tests/test_scripts.py::test_f2py[f2py]

@seberg
Copy link
Member

seberg commented Jul 9, 2025

Not sure how to retrieve detailed logs to fix these issues:

Just scroll up? It may be very hard to get xfail strict to work and I am not sure we should ship that, because we won't test all weird platforms.

Apply Repo-Review suggestions PP306, PP307, PP308. Skip PP305 for now.
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review July 12, 2025 12:38
@seberg seberg changed the title MNT: Options to catch more issues reported by pytest MAINT: Options to catch more issues reported by pytest Jul 14, 2025
@seberg
Copy link
Member

seberg commented Jul 14, 2025

OK, lets just add this strict ones (I wonder if warning->error option already does it implicitly, but doesn't hurt). Thanks.

@seberg seberg merged commit 9173e54 into numpy:main Jul 14, 2025
76 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the pytest branch July 14, 2025 14:53
@DimitriPapadopoulos DimitriPapadopoulos restored the pytest branch July 14, 2025 14:53
@DimitriPapadopoulos DimitriPapadopoulos deleted the pytest branch July 14, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants