Skip to content

TYP: Fix non-existent CanIndex annotation in ndarray.setfield #28908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

TYP: Fix non-existent CanIndex annotation in ndarray.setfield #28908

merged 1 commit into from
May 6, 2025

Conversation

MarcoGorelli
Copy link
Member

I think this was set incorrectly in #28540, CanIndex is not defined here and is the name used in NumType

@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 6, 2025 09:11
@jorenham
Copy link
Member

jorenham commented May 6, 2025

Ohh good catch!

@jorenham jorenham merged commit bec11a4 into numpy:main May 6, 2025
76 checks passed
@jorenham
Copy link
Member

jorenham commented May 6, 2025

Thanks!

@jorenham jorenham added the 09 - Backport-Candidate PRs tagged should be backported label May 6, 2025
@charris charris mentioned this pull request May 6, 2025
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 6, 2025
@MarcoGorelli MarcoGorelli mentioned this pull request May 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
41 - Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @jorenham @charris