Skip to content

TYP: fix typing errors in _core.strings #28585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

charris
Copy link
Member

@charris charris commented Mar 25, 2025

Backport of #28492.

Backport of numpy/numtype#115


  • fixed the incorrect signatures of np.strings.{add,rstrip,startswith}
  • removed the non-existent np.strings.join function
  • removed incorrect "fail" type-tests for np.strings.{l,r}just
  • annotated np._core.strings.__all__

@charris charris added 08 - Backport Used to tag backport PRs 41 - Static typing numtype Isssue/PR related to numpy/numtype labels Mar 25, 2025
@charris charris added this to the 2.2.5 release milestone Mar 25, 2025
@charris charris merged commit 3c7c3e7 into numpy:maintenance/2.2.x Mar 25, 2025
70 checks passed
@charris charris deleted the backport-28492 branch March 25, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 - Backport Used to tag backport PRs 41 - Static typing numtype Isssue/PR related to numpy/numtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants