CI: Update FreeBSD base image in cirrus_arm.yml
#28328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BUG]: Change Freebsd image
rgommers
changed the title
cirrus_arm.yml
rgommers
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Thanks @abhishek-iitmadras! This change is clearly correct.
It does show one new test failure, so the job isn't passing yet:
___________ TestStringDiscovery.test_nested_arrays_stringlength[1.2] ___________
self = <test_array_coercion.TestStringDiscovery object at 0x1a16d2f95dd0>
obj = 1.2
@pytest.mark.parametrize("obj",
[object(), 1.2, 10**43, None, "string"],
ids=["object", "1.2", "10**43", "None", "string"])
def test_nested_arrays_stringlength(self, obj):
length = len(str(obj))
expected = np.dtype(f"S{length}")
arr = np.array(obj, dtype="O")
> assert np.array([arr, arr], dtype="S").dtype == expected
E RuntimeWarning: invalid value encountered in cast
arr = array(1.2, dtype=object)
expected = dtype('S3')
length = 3
obj = 1.2
self = <test_array_coercion.TestStringDiscovery object at 0x1a16d2f95dd0>
../.venv/lib/python3.11/site-packages/numpy/_core/tests/test_array_coercion.py:180: RuntimeWarning
I think I'll merge this as is and the failure can be taken care of separately, since this PR is an improvement already (the job is failing on all PRs right now).
|
I'll open a new issue for the test failure, since I'm not sure what is going on there. |
This was referenced Feb 13, 2025
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Freebsd image as per https://cirrus-ci.org/guide/FreeBSD/