Skip to content

TYP: fix positional- and keyword-only params in astype, cross and linalg #28327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2025
Merged

TYP: fix positional- and keyword-only params in astype, cross and linalg #28327

merged 2 commits into from
Feb 15, 2025

Conversation

Andrej730
Copy link
Contributor

Example:

import numpy as np
lst = np.eye(3)
# No typing issues but on runtime:
# TypeError: astype() got some positional-only arguments passed as keyword arguments: 'x, dtype'
np.astype(x=lst, dtype=np.float64)

@Andrej730
Copy link
Contributor Author

@jorenham Sorry, not sure who to ping - can you please take a look?

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Andrej730 Andrej730 changed the title Fix missing argument flags in typing TYP: fix missing argument flags in typing Feb 13, 2025
@jorenham jorenham changed the title TYP: fix missing argument flags in typing TYP: fix positional- and keyword-only parameters in astype and linalg Feb 13, 2025
@jorenham
Copy link
Member

Looks good! Could you squash your commits and prepend TYP: to the message(s)?

tylerjereddy
tylerjereddy reviewed Feb 13, 2025
View reviewed changes
@charris charris added 41 - Static typing 09 - Backport-Candidate PRs tagged should be backported labels Feb 13, 2025
@jorenham jorenham self-requested a review February 14, 2025 20:51
@jorenham jorenham changed the title TYP: fix positional- and keyword-only parameters in astype and linalg TYP: fix positional- and keyword-only params in astype, cross and linalg Feb 15, 2025
@jorenham jorenham merged commit e20317a into numpy:main Feb 15, 2025
69 of 70 checks passed
@jorenham
Copy link
Member

Thanks Andrej!

@Andrej730 Andrej730 deleted the fix_typing_arguments branch February 16, 2025 17:25
@charris charris mentioned this pull request Feb 17, 2025
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Feb 17, 2025
@jorenham jorenham mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy left review comments

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
41 - Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andrej730 @jorenham @tylerjereddy @charris