431: Throw error if database id was not provided

KoditkarVedant · KoditkarVedant · commit 80d32df3b950 · 2025-04-12T17:32:06.000+05:30
diff --git a/Src/Notion.Client/Api/Databases/DatabasesClient.cs b/Src/Notion.Client/Api/Databases/DatabasesClient.cs
@@ -1,4 +1,5 @@
-﻿using System.Threading;
+﻿using System;
+using System.Threading;
 using System.Threading.Tasks;
 using static Notion.Client.ApiEndpoints;
 
@@ -15,6 +16,11 @@ public DatabasesClient(IRestClient client)
 
         public async Task<Database> RetrieveAsync(string databaseId, CancellationToken cancellationToken = default)
         {
+            if (string.IsNullOrWhiteSpace(databaseId))
+            {
+                throw new ArgumentNullException(nameof(databaseId));
+            }
+
             return await _client.GetAsync<Database>(DatabasesApiUrls.Retrieve(databaseId), cancellationToken: cancellationToken);
         }
 
diff --git a/Test/Notion.UnitTests/DatabasesClientTests.cs b/Test/Notion.UnitTests/DatabasesClientTests.cs
@@ -504,4 +504,18 @@ var jsonData
             formulaPropertyValue.Formula.Date.End.Should().BeNull();
         }
     }
+
+    [Theory]
+    [InlineData(null)]
+    [InlineData("")]
+    [InlineData("        ")]
+    public async Task RetrieveAsync_throws_argument_null_exception_if_database_id_is_null_or_empty(string databaseId)
+    {
+        // Arrange && Act
+        async Task<Database> Act() => await _client.RetrieveAsync(databaseId);
+
+        // Assert
+        var exception = await Assert.ThrowsAsync<ArgumentNullException>(Act);
+        Assert.Equal("databaseId", exception.ParamName);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -504,4 +504,18 @@ var jsonData`
`504`	`504`	`formulaPropertyValue.Formula.Date.End.Should().BeNull();`
`505`	`505`	`}`
`506`	`506`	`}`
	`507`	`+`
	`508`	`+ [Theory]`
	`509`	`+ [InlineData(null)]`
	`510`	`+ [InlineData("")]`
	`511`	`+ [InlineData(" ")]`
	`512`	`+ public async Task RetrieveAsync_throws_argument_null_exception_if_database_id_is_null_or_empty(string databaseId)`
	`513`	`+ {`
	`514`	`+ // Arrange && Act`
	`515`	`+ async Task<Database> Act() => await _client.RetrieveAsync(databaseId);`
	`516`	`+`
	`517`	`+ // Assert`
	`518`	`+ var exception = await Assert.ThrowsAsync<ArgumentNullException>(Act);`
	`519`	`+ Assert.Equal("databaseId", exception.ParamName);`
	`520`	`+ }`
`507`	`521`	`}`