feat(etherscan-api): added Paging to txlist

sebs · sebs · commit 15ad4ff062b7 · 2019-09-20T11:28:27.000+02:00
diff --git a/packages/etherscan-api/Readme.md b/packages/etherscan-api/Readme.md
@@ -0,0 +1,2 @@
+# etherscan-api 
+
diff --git a/packages/etherscan-api/src/Client.ts b/packages/etherscan-api/src/Client.ts
@@ -38,6 +38,7 @@ import { Address } from './entities/Address'
 import { ApiKey } from './entities/Apikey'
 import { Clienttype } from './entities/Clienttype'
 import { Network } from './entities/Network'
+import { Paging } from './entities/Paging'
 import { PositiveNumber } from './entities/PositiveNumber'
 import { Sort } from './entities/Sort'
 import { Syncmode } from './entities/Syncmode'
@@ -487,10 +488,17 @@ export class Client {
           json,
         ).then((response) => response.json())
       },
-      txlist(address: string, startblock: string, endblock: string, sort?: string): Promise<any> {
+      txlist(
+          address: string,
+          startblock: string,
+          endblock: string,
+          sort?: string,
+          page?: string,
+          offset?: string): Promise<any> {
         const oAddress = new Address(address)
         const oSort = !!sort ? new Sort(sort) : undefined
-        const client = new ClientAccountTxlist(oAddress, startblock, endblock, oSort)
+        const paging = !!page && !!offset ? new Paging(new PositiveNumber(page), new PositiveNumber(offset)) : undefined
+        const client = new ClientAccountTxlist(oAddress, startblock, endblock, oSort, paging)
         const json = client.toJson()
         json.apiKey = apiKey.toString()
         return performRequest(
diff --git a/packages/integration-test-browser/test/account-test.js b/packages/integration-test-browser/test/account-test.js
@@ -23,11 +23,12 @@ describe('client', function () {
 				throw new Error(err)
 			})
 		})
-
-		it('balance', function (done) {
+		it('balancemulti', function (done) {
 			this.retries(3)
 			const client = new EtherscanClient.Client(validApiKey);
-			const promise = client.account('balance')('0xde0b295669a9fd93d5f28d9ec85e40f4cb697bae', 'latest')
+			const promise = client.account('balancemulti')([
+				'0xde0b295669a9fd93d5f28d9ec85e40f4cb697bae'
+			], 'latest')
 			promise.then(res => {
 				assert.ok(res)
 				assert.ok(res.status)
@@ -37,12 +38,14 @@ describe('client', function () {
 				throw new Error(err)
 			})
 		})
-		it('balancemulti', function (done) {
+		it('txlist', function (done) {
 			this.retries(3)
 			const client = new EtherscanClient.Client(validApiKey);
-			const promise = client.account('balancemulti')([
-				'0xde0b295669a9fd93d5f28d9ec85e40f4cb697bae'
-			], 'latest')
+			const address = '0xde0b295669a9fd93d5f28d9ec85e40f4cb697bae'
+			const startblock = 0
+			const endblock = 99999999
+			const sort = 'asc'
+			const promise = client.account('txlist')(address, startblock, endblock, sort)
 			promise.then(res => {
 				assert.ok(res)
 				assert.ok(res.status)
@@ -51,7 +54,24 @@ describe('client', function () {
 			}).catch(err => {
 				throw new Error(err)
 			})
-		})
+		})	
+		it('txlist paged', function (done) {
+			this.retries(3)
+			const client = new EtherscanClient.Client(validApiKey);
+			const address = '0xde0b295669a9fd93d5f28d9ec85e40f4cb697bae'
+			const startblock = 0
+			const endblock = 99999999
+			const sort = 'asc'
+			const promise = client.account('txlist')(address, startblock, endblock, sort, 1, 100)
+			promise.then(res => {
+				assert.ok(res)
+				assert.ok(res.status)
+				assert.equal(res.status, 1)
+				done()
+			}).catch(err => {
+				throw new Error(err)
+			})
+		})	
 	})
 
 	describe('contract', ()=> {
