Skip to content

Add Multiwavelet Neural Operator #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shixuan01
Copy link

This version updates the Multiwavelet Neural Operator, adds mwt.py in the neuralop/models/ directory, and adds mwt_utils.y in neuralop/ as a set of mwt utility functions.

Copy link
Member

@dhpitt dhpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. Really exciting to have your contribution! Before we integrate this into the library, it would be awesome to refactor the layers to be dimension-agnostic and follow the modular design of the FNO currently in the library.

if self.n_dim == 1:
alpha = n_modes[0]
ich_multiplier = c * k
MWT_CZ_class = MWT_CZ1d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really preferable if the key operations could be refactored to be dim-agnostic.

@@ -0,0 +1,190 @@
import torch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions should go in a layer/submodule file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants